Re: [PATCH 2/2] dt-bindings: phy: ti,phy-usb3: document aspcie reference clock setting
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.infradead.lists.linux-phy,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 05/08/2026 10:42, David Oberhollenzer wrote: > Hi, > > On 8/5/26 9:39 AM, Krzysztof Kozlowski wrote: >> >> Not a valid naming, missing vendor prefix and syscon looks like >> Linuxism, since you called it "system control module". >> > > I agree that this is a very vendor specific kluge and I suspected > it might need a vendor prefix. However, I ultimately tried to stick > to existing conventions. > > There are 3 more syscon properties defined for this device: > - syscon-phy-power > - syscon-pllreset > - syscon-pcs These, as the rest of the binding come, from 2015 or even earlier. A lot changed during that time. It is a good idea to take recently reviewed code as an example. It is a bad idea to take 10 yo code. > > None of them have a vendor prefix, all of them use the > description "system control module". > > I take it, the existing properties already break best practices > that were established later? Or is there another reason they > lack a vendor prefix? Just add vendor prefix to the new property. > >>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>> + maxItems: 1 >>> + items: >>> + items: >> >> Missing - >> > Likewise, I simply copied from the syscon blocks and made some > minor changes. Hence also the identical description. So this is > broken for the existing properties as well? Hm, you are right, the syntax was actually correct. I missed maxItems. Preferred syntax is for example in Documentation/devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml, but your code was fine as well. Best regards, Krzysztof -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy