Re: [PATCH 3/8] dt-bindings: usb: generic-ehci: Document access-controllers property
| Newsgroups | org.infradead.lists.linux-phy,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incomplete schema update: `access-controllers` is added to EHCI but omitted from the companion OHCI binding. -- --- Patch [3]: [PATCH 3/8] dt-bindings: usb: generic-ehci: Document access-controllers property --- commit 5a4a63ad96f05ab82966f723bbb1698bcfb4356a Author: Marek Vasut <[email protected]> dt-bindings: usb: generic-ehci: Document access-controllers property This commit adds the access-controllers property to the generic EHCI USB controller device tree binding schema. This allows access checks to be documented for these controllers. > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > index 55a5aa7d7a54e..602241887d995 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > @@ -80,6 +80,9 @@ properties: > minItems: 1 > maxItems: 2 > > + access-controllers: > + maxItems: 1 > + [Severity: Low] Does this property also need to be added to the generic OHCI binding (generic-ohci.yaml) or a common schema like usb-hcd.yaml? If a device tree configures both an EHCI controller and its companion OHCI controller behind an access controller, the OHCI node might fail dt_binding_check validation because generic-ohci.yaml enforces unevaluatedProperties: false. > dma-coherent: true -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy