Re: [PATCH 0/9] PCI: qcom: Add PCIe support for Shikra SoC
Sushrut Shree Trivedi <[email protected]>
| Newsgroups | org.infradead.lists.linux-phy,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
On 7/8/2026 1:32 PM, Manivannan Sadhasivam wrote: > On Wed, Jul 01, 2026 at 12:32:42AM +0530, Sushrut Shree Trivedi wrote: >> Add PCIe support for Shikra target, by adding dt-bindings for phy, >> controller and corresponding phy & controller drivers/device-tree >> changes. >> >> Shikra RC is connected to TC9563 PCIe switch on all three >> EVK variants: CQS, CQM and IQS. The individual downstream ports >> of TC9563 connect like below: >> >> DSP1: M.2 B-Key for 5G Modem >> DSP2: M.2 M-Key for NVMe >> DSP3: Embedded ethernet device >> >> Power and reset to M.2 B and M.2 M slot are controlled via >> TC9563 GPIO's. Hence, add DT nodes to enable TC9563 switch >> and include corresponding changes to configure power/reset >> to TC9563 endpoints as part of power on sequence. >> >> Signed-off-by: Sushrut Shree Trivedi <[email protected]> >> --- >> Sushrut Shree Trivedi (9): >> dt-bindings: phy: sc8280xp-qmp-pcie: Document Shikra PCIe phy >> dt-bindings: PCI: qcom: Document the Shikra PCIe Controller >> dt-bindings: PCI: Add bindings for endpoint gpios >> PCI: qcom: Add support for Shikra >> phy: qcom: qmp-pcie: Add QMP PCIe PHY support for Shikra >> PCI/pwrctrl: tc9563: Add API to control endpoint power and reset > TC9563 should be modeled as a GPIO controller to drive the PERST# and power-on > GPIOs. There is a patch series under review [1] that adds this support. So it > doesn't make sense to duplicate the effort here (which itself is hackish). So > please drop all the switch related patches from this series and resubmit them > once the above mentioned series from Alex gets merged. > > But you can continue with the Shikra PCIe RC/PHY patches. > > - Mani > > [1] https://lore.kernel.org/all/[email protected] ACK'd > >> arm64: dts: qcom: shikra: Add PCIe PHY and controller nodes >> arm64: dts: qcom: shikra-evk: Add TC9563 PCIe switch node for PCIe >> arm64: dts: qcom: shikra-(cqm/cqs/iqs)-evk: Enable PCIe PHY node >> >> .../devicetree/bindings/pci/qcom,shikra-pcie.yaml | 211 +++++++++++++++++++++ >> .../devicetree/bindings/pci/toshiba,tc9563.yaml | 22 ++- >> .../bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 2 + >> arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 7 + >> arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 7 + >> arch/arm64/boot/dts/qcom/shikra-evk.dtsi | 152 +++++++++++++++ >> arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 7 + >> arch/arm64/boot/dts/qcom/shikra.dtsi | 154 +++++++++++++++ >> drivers/pci/controller/dwc/pcie-qcom.c | 1 + >> drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 152 ++++++++++++--- >> drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 73 +++++++ >> 11 files changed, 764 insertions(+), 24 deletions(-) >> --- >> base-commit: 565fa02f75448ce1ddd18bda6b31ad985cf75411 >> change-id: 20260701-shikra-upstream-14b8668f1001 >> >> Best regards, >> -- >> Sushrut Shree Trivedi <[email protected]> >> >> -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy