Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The schema modification unconditionally mandates 5 clocks for `qcom,ipq5332-dwc3`, breaking validation for existing valid device trees that provide only 3 clocks for High-Speed-only configurations.
--
--- Patch [6]: [PATCH v2 06/14] dt-bindings: usb: qcom,snps-dwc3: Add clocks for USB3 on Qualcomm IPQ5332 ---
commit 76251f6cda12ef34d26acca7a91c897245bd05c0
Author: Praveenkumar I <[email protected]>
dt-bindings: usb: qcom,snps-dwc3: Add clocks for USB3 on Qualcomm IPQ5332
This commit adds aux and lfps clocks for the Qualcomm IPQ5332 platform in the
qcom,snps-dwc3 bindings, splitting it from the qcom,ipq4019-dwc3 block.
> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> index 8201656b41ed7..e59fbfc1af71b 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
[ ... ]
> @@ -182,6 +181,25 @@ allOf:
> - const: sleep
> - const: mock_utmi
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,ipq5332-dwc3
> + then:
> + properties:
> + clocks:
> + minItems: 5
> + maxItems: 5
[Severity: High]
The commit message states that the aux and lfps clocks are required only for
USB Super-Speed support. Does setting minItems to 5 unconditionally break
schema validation for existing High-Speed-only device trees that only supply
the core, sleep, and mock_utmi clocks?
If these clocks are optional depending on the hardware configuration, should
minItems remain 3 with the additional clocks defined as optional items?
> + clock-names:
> + items:
> + - const: core
> + - const: sleep
> + - const: mock_utmi
> + - const: aux
> + - const: lfps
> +
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6
--
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.