Re: [PATCH v2 09/14] arm64: dts: qcom: ipq5018: Add clocks required for USB3 support
| Newsgroups | org.infradead.lists.linux-phy,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The patch adds `assigned-clocks` and `assigned-clock-rates` to hardcode specific clock frequencies, which is completely undocumented in the commit message. -- --- Patch [9]: [PATCH v2 09/14] arm64: dts: qcom: ipq5018: Add clocks required for USB3 support --- commit 339a6b4d83bd552f4fe80b1ff4d6d41390119b3a Author: George Moussalem <[email protected]> arm64: dts: qcom: ipq5018: Add clocks required for USB3 support This commit adds the auxiliary and LFPS clocks to the USB controller node in the IPQ5018 device tree to enable Super-Speed (USB3) mode. It also sets default assigned clocks and clock rates for the controller. > diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi > --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi > @@ -591,11 +591,21 @@ usb: usb@8a00000 { [ ... ] > clock-names = "core", > "iface", > "sleep", > - "mock_utmi"; > + "mock_utmi", > + "aux", > + "lfps"; > + assigned-clocks = <&gcc GCC_USB0_MASTER_CLK>, > + <&gcc GCC_SYS_NOC_USB0_AXI_CLK>, > + <&gcc GCC_USB0_MOCK_UTMI_CLK>; > + assigned-clock-rates = <200000000>, > + <200000000>, > + <60000000>; [Severity: Medium] The commit message mentions adding the aux and lfps clocks for USB3 support, but does not document adding these assigned-clocks and assigned-clock-rates. Could the commit message be updated to explain the rationale for forcing these specific 200MHz and 60MHz frequencies during initialization? -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=9 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy