Re: [PATCH v2 05/14] arm64: dts: qcom: ipq5018: Flatten usb controller node
| Newsgroups | org.infradead.lists.linux-phy,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] The flattened `qcom,snps-dwc3` node provides a `reg` memory region size (`0xe000`) that is too small to cover the qscratch wrapper registers, leading to a `-EBUSY` probe failure. -- --- Patch [5]: [PATCH v2 05/14] arm64: dts: qcom: ipq5018: Flatten usb controller node --- commit e097cafa032cb2e224c3052691cef507b25b9831 Author: George Moussalem <[email protected]> arm64: dts: qcom: ipq5018: Flatten usb controller node This commit flattens the USB controller node and updates it to use the latest bindings and flattened driver approach. > diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi > index abd12b31a5147..7b8c9465f4442 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi [ ... ] > - usb: usb@8af8800 { > - compatible = "qcom,ipq5018-dwc3", "qcom,dwc3"; > - reg = <0x08af8800 0x400>; > - > - interrupts = <GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; > - interrupt-names = "pwr_event", > - "dp_hs_phy_irq", > - "dm_hs_phy_irq"; > + usb: usb@8a00000 { > + compatible = "qcom,ipq5018-dwc3", "qcom,snps-dwc3"; > + reg = <0x08a00000 0xe000>; [Severity: High] Does this reg size correctly cover the qscratch wrapper registers? The Qualcomm wrapper driver (dwc3-qcom.c) artificially expands the memory resource size up to the 0xf8800 offset. Since the new flattened node here only allocates a length of 0xe000 bytes, won't devm_ioremap_resource() fail with -EBUSY during probe when the core driver requests a region that extends beyond this parent device boundary? -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy