Re: [PATCH v2 11/14] arm64: dts: qcom: ipq5018: Add Super-Speed UNIPHY to USB node

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Removing `qcom,select-utmi-as-pipe-clk` from the base `.dtsi` breaks USB initialization on boards that do not enable `usbphy1` (USB 2.0-only configurations).
--

--- Patch [11]: [PATCH v2 11/14] arm64: dts: qcom: ipq5018: Add Super-Speed UNIPHY to USB node ---
commit cad428ffac4e6a077748bf0a342a5d6933fea31b
Author: George Moussalem <[email protected]>

arm64: dts: qcom: ipq5018: Add Super-Speed UNIPHY to USB node

This commit adds the USB3 UNIPHY node to the USB controller node in the
IPQ5018 device tree. It also removes the property that selects the UTMI
clock as the pipe clock, expecting the pipe clock to be supplied by the
USB3 UNIPHY instead.

> diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> index 82e9ba6020ebd..87c3ade70217f 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> @@ -618,10 +618,8 @@ usb: usb@8a00000 {
>  
>  			resets = <&gcc GCC_USB0_BCR>;
>  
> -			phys = <&usbphy0>;
> -			phy-names = "usb2-phy";
> -
> -			qcom,select-utmi-as-pipe-clk;

[Severity: High]
Will removing this property break boards that do not enable usbphy1?

For example, looking at arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts,
it configures USB but lacks usbphy1:

&usb {
        dr_mode = "host";

        status = "okay";
};

Because qcom,select-utmi-as-pipe-clk is no longer in the base device tree,
the dwc3-qcom wrapper won't fall back to the UTMI clock.

Since usbphy1 is disabled on these USB 2.0-only configurations, the PHY
driver doesn't probe and the pipe clock is never provided. Does this cause
the dwc3 controller to hang while waiting for a non-existent clock during
initialization?

> +			phys = <&usbphy0>, <&usbphy1>;
> +			phy-names = "usb2-phy", "usb3-phy";
>  
>  			tx-fifo-resize;
>  			snps,is-utmi-l1-suspend;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=11

-- 
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy