Re: [PATCH 1/8] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY

On 8/12/26 12:15 PM, Krzysztof Kozlowski wrote:
> On Wed, Aug 12, 2026 at 02:55:41AM +0200, Marek Vasut wrote:
>> From: Pankaj Dev <[email protected]>
>>
>> Document USB2 PHY for STM32MP25 USB2 controllers, which includes the
>> USB2.0 host-only controller and USB 2.0 part of the DWC3 controller.
>> Two such PHYs in total are present in STM32MP25 SoC, they both are
>> slightly different, therefore they use different compatible string
> 
> What is slightly different? This should be either here, or better, in
> "description" part.

They are both Synopsys FEMTO-PHY , but they are each attached to a 
different controller (one to USB 2.0 host , the other to DWC3 DRD) , and 
their control bits in the system controller register are different for 
each variant.

I extended the description in V2.

>> to discern them.
>>
>> Signed-off-by: Clément Le Goffic <[email protected]>
>> Signed-off-by: Fabrice Gasnier <[email protected]>
>> Signed-off-by: Marek Vasut <[email protected]>
>> Signed-off-by: Pankaj Dev <[email protected]>
>> Signed-off-by: Rahul Kumar <[email protected]>
> 
> Incomplete/incorrect DCO chain. Who sends it? Rahul?
This is lifted from the ST downstream kernel fork, it's a combination of 
a bunch of commits there and then cleaned up. Pankaj and Fabrice did 
most of the downstream work, I did the clean up for upstreaming. I 
collected the SoB lines from all the commits from ST downstream fork and 
added mine, hence this list. How shall I address this correctly, with 
some Co-developed-by tag ? Who gets which tag ?

additionalProperties is addressed in V2, so is the reported from Rob's 
bot regarding the botched compatible string in example.

Thanks !

-- 
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy