Re: [PATCH v9 2/5] phy: qualcomm: hdmi-28lpm: provide dynamic configuration
Dmitry Baryshkov <[email protected]>
| Newsgroups | org.infradead.lists.linux-phy,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <w6mq6a63mjzhjirvvgetcdptutkq3upa5v5kmdcezjke6rhkm3@lctdutlbnbud> |
On Wed, Aug 12, 2026 at 03:51:16PM +0200, Manivannan Sadhasivam wrote: > On Wed, May 13, 2026 at 09:14:05PM +0300, Dmitry Baryshkov wrote: > > Replace fixed value configuration tables with the values calculated at > > the runtime. In some cases the values might differ from the original > > values. Those were validated on the IFC6410 board. > > > > Signed-off-by: Dmitry Baryshkov <[email protected]> > > One nit below. With that fixed, > > Acked-by: Manivannan Sadhasivam <[email protected]> > > > --- > > drivers/phy/qualcomm/phy-qcom-hdmi-28lpm.c | 325 +++++++++-------------------- > > 1 file changed, 104 insertions(+), 221 deletions(-) > > > > -static const struct pll_rate *qcom_hdmi_8960_pll_find_rate(unsigned long rate) > > +static inline void write16(u16 val, void __iomem *reg) > > No 'inline' keyword in .c files please. Why? > > - Mani > > -- > மணிவண்ணன் சதாசிவம் -- With best wishes Dmitry -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy