Re: [PATCH v2 5/9] dt-bindings: usb: dwc3: Document ST STM32MP2 DWC3 xHCI USB controller
| Newsgroups | org.infradead.lists.linux-phy,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The st,stm32mp25-dwc3.yaml schema defines a flattened DWC3 controller node and sets `unevaluatedProperties: false`, but omits the required `$ref` to the standard DWC3 common schema (`snps,dwc3-common.yaml#`). This causes all standard generic USB properties (e.g., `usb-role-switch`, `maximum-speed`) and DWC3 quirks (`snps,*`) to be improperly rejected during device tree validation. -- --- Patch [5]: [PATCH v2 5/9] dt-bindings: usb: dwc3: Document ST STM32MP2 DWC3 xHCI USB controller --- commit 1e1f5ec0770c94ae4e8d9d9545d561a05a898622 Author: Marek Vasut <[email protected]> dt-bindings: usb: dwc3: Document ST STM32MP2 DWC3 xHCI USB controller The ST STM32MP2 SoC contains a single instance of a DWC3 USB controller with a glue logic wrapper. This commit adds the device tree binding schema to document the controller and its syscon-controlled wrapper. > diff --git a/Documentation/devicetree/bindings/usb/st,stm32mp25-dwc3.yaml b/Documentation/devicetree/bindings/usb/st,stm32mp25-dwc3.yaml > new file mode 100644 > index 0000000000000..e377efef43503 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/st,stm32mp25-dwc3.yaml [ ... ] > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - phys > + - phy-names > + - resets > + - st,syscfg > + > +unevaluatedProperties: false [Severity: Medium] Will setting unevaluatedProperties: false without a $ref to snps,dwc3-common.yaml# prevent the use of standard generic USB properties? Because this block strictly restricts allowed properties to those defined locally, it appears standard DWC3 quirks and generic USB properties like usb-role-switch or maximum-speed might be improperly rejected during device tree validation. > + > +examples: > + - | > + #include <dt-bindings/clock/st,stm32mp25-rcc.h> -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy