Re: [PATCH v2 1/2] dt-bindings: phy: ti,phy-usb3: Add aspcie reference clock setting

Hi,

On 8/12/26 4:20 AM, Rob Herring wrote:
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: ti,phy-pipe3-pcie
>> +    then:
>> +      properties:
>> +        ti,syscon-acspcie-tx-rx: true
> 
> This has no effect. Invert the if and move the else here.
> 

Before I send another version of this patch set, are you really
sure about this?

Not only did I copy that entire block from the one directly above,
(the one that is supposed to only allow syscon-pllreset compatible
is set to ti,phy-pipe3-sata), I actually tested this by running
make dt_binding_check.

If I intentionally break the example by setting a wrong compatible
string, I get a "False schema does not allow" type message, same
as when I use the syscon-pllreset property with the wrong compat
string.

Is the existing check broken too? Is there something different
supposed to happen?

Greetings,

David


-- 
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy