Re: [PATCH v2 01/14] dt-bindings: phy: Document the Qualcomm IPQ5332 UNIPHY USB Super-speed PHY
Konrad Dybcio <[email protected]>
| Newsgroups | org.infradead.lists.linux-phy,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <[email protected]> |
On 8/13/26 12:48 PM, Krzysztof Kozlowski wrote:
> On 13/08/2026 12:28, George Moussalem wrote:
>>>> +examples:
>>>> + - |
>>>> + #include <dt-bindings/clock/qcom,ipq5332-gcc.h>
>>>> +
>>>> + phy@4b0000 {
>>>> + compatible = "qcom,ipq5332-uniphy-usb-ss-phy";
>>>> + reg = <0x4b0000 0x800>;
>>>
>>> That is the same address as PCI PHY, so you have one device, not two.
>>
>> yes, AFAIK they're separate PHYs (pcie-28lp vs usb-ss-22ull) sharing the
>> same MMIO register space in IPQ5332. To enable USB3, the compatible
>> string, clocks, resets, and related USB3 properties override the PCIe
>> properties. In IPQ5018, the PHYs have different register address spaces,
>> hence representing it as a new devicetree node.
>>
>
> Same MMIO space is same device, IMO, especially that you have the same
> registers (looking at the driver).
It's indeed one device, fittingly named "PCIE+USB COMBO PHY"
Konrad
--
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy