Re: [PATCH] phy: qualcomm: qmp-combo: update DP PHY PLL programming on Glymur

Correcting myself. My earlier reply was wrong and I apologise for the noise.

I said the include had "dp" and "qserdes" transposed. It does not. The file

  drivers/phy/qualcomm/phy-qcom-qmp-dp-qserdes-com-v8.h

exists in v7.2 and the include was correct when this patch was posted on
21 July. I checked only current linux-next and drew the wrong conclusion.

What actually changed is a later cleanup.

  4b04c8779a50 ("phy: qcom-qmp: qserdes-com: drop duplicate v8 DP headers")

authored 22 July, merged 7 August. It removed that header as a duplicate of
phy-qcom-qmp-qserdes-dp-com-v8.h, reverting d10736db98d2. So the build break
on current linux-next is a rebase consequence, not an error in the patch.

The practical fix is unchanged. On a tree that has 4b04c8779a50, the include
needs to become

  #include "phy-qcom-qmp-qserdes-dp-com-v8.h"

which still supplies DP_QSERDES_V8_COM_C_READY_STATUS and
DP_QSERDES_V8_COM_CMN_STATUS.

The other point in my earlier reply stands. eca0e717aab1 ("phy: qualcomm:
qmp-combo: Add support for Hawi SoC") added lines to the same include block
on 3 August, so "git am -3" is needed to apply this cleanly.

Sorry again for the misdiagnosis.

Thanks,
Jason

-- 
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy