Re: [PATCH v2] i2c: spacemit: request IRQ after controller initialization
Andi Shyti <[email protected]>
| Newsgroups | org.infradead.lists.linux-riscv,dev.linux.lists.spacemit,org.kernel.vger.linux-i2c,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
Hi Linmao,
Please, next time don't send the v2 as a reply to v1, it makes
things confusing.
On Thu, Jul 23, 2026 at 10:11:40AM +0800, Linmao Li wrote:
> spacemit_i2c_probe() requests the IRQ before it enables the clocks, resets
> the controller and runs init_completion(). If an interrupt is already
> pending, the handler runs too early: it reads registers while the clocks
> are still off and calls complete() on an uninitialized completion. Request
> the IRQ after the controller and completion are initialized, but still
> before the adapter is registered.
>
> Fixes: 5ea558473fa3 ("i2c: spacemit: add support for SpacemiT K1 SoC")
> Cc: [email protected] # v6.15+
> Signed-off-by: Linmao Li <[email protected]>
> Reviewed-by: Troy Mitchell <[email protected]>
> Reviewed-by: Alex Elder <[email protected]>
> ---
> v2:
> - add Cc: stable # v6.15+ as requested by Troy Mitchell
> - collect Reviewed-by from Troy Mitchell and Alex Elder
No need to send a v2 just to update the tag section.
Merged to i2c/i2c-fixes.
Thanks,
Andi
> drivers/i2c/busses/i2c-k1.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv