Re: [PATCH 1/2] riscv: dts: spacemit: Fix phy id check for the phy on pico-itx board

Hi E Shattow,

On 01:12 Sat 25 Jul     , E Shattow wrote:
> Hi Inochi,
> 
> On 7/24/26 17:58, Inochi Amaoto wrote:
> > Current phy framework can not reinit the phy correctly, as it will
> > assert the phy reset GPIO so the phy id can not be readed. Setting
> > the phy id of board pico-itx manually so the phy id dectection can
> > be skipped.
> > 
> > Fixes: 74657a376960 ("riscv: dts: spacemit: Add ethernet device for K3")
> > Reported-by: E Shattow <[email protected]>
> > Reported-by: Inochi Amaoto <[email protected]>
> > Closes: https://lore.kernel.org/netdev/[email protected]
> > Signed-off-by: Inochi Amaoto <[email protected]>
> > Tested-by: E Shattow <[email protected]>
> > ---
> >  arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > index b2a7d2d0d3a8..b9d2de878f38 100644
> > --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > @@ -196,7 +196,8 @@ &eth0 {
> >  
> >  	mdio {
> >  		phy0: phy@1 {
> > -			compatible = "ethernet-phy-ieee802.3-c22";
> > +			compatible = "ethernet-phy-id001c.c916",
> > +				     "ethernet-phy-ieee802.3-c22";
> >  			reg = <1>;
> >  			reset-gpios = <&gpio 0 15 GPIO_ACTIVE_LOW>;
> >  			reset-assert-us = <10000>;
> 
> Looks good to me, aside from commit message spelling and grammar nits
> ("re-initialize", "read", "detection"). Yixun may just fix in-flight, my
> R-by and T-by tags can stay.
> 
Yes, I will fix them while applying, no need to resend, thanks for review

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv