Re: [PATCH v2 3/3] dt-bindings: sifive: Add WorldGuard Checker

Yu-Chien Peter Lin <[email protected]>
Newsgroups org.infradead.lists.linux-riscv,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID <anruhbTLRRMVa4Ia@plin-1878>
On Thu, Jul 30, 2026 at 09:37:11AM +0200, Krzysztof Kozlowski wrote:
> On 30/07/2026 09:35, Krzysztof Kozlowski wrote:
> >> +allOf:
> >> +  - $ref: /schemas/access-controllers/access-controllers.yaml#
> >> +
> >> +properties:
> >> +  compatible:
> >> +    oneOf:
> >> +      - items:
> >> +          - const: qemu,wgchecker2
> >> +          - const: sifive,wgchecker2
> >> +      - const: sifive,wgchecker2
> > 
> > You need soc specific compatibles.
> > 
> > I do not believe the two review tags did any actual real review. They
> > would tell you to read writing bindings document, wouldn't they?
> 
> 
> And you WERE TOLD this already at v1 - missing device specific compatibles.
> 
> Drop all review tags here, they did not happen.

Understood.

Best regards,
Peter Lin

> 
> Best regards,
> Krzysztof

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.