Re: [PATCH 03/16] irqchip/sifive-plic: do not iounmap devm mappings

Thomas Gleixner <[email protected]>
Newsgroups org.infradead.lists.linux-riscv,org.kernel.vger.linux-kernel
Message-ID <874igpjo2x.ffs@fw13>
On Tue, Jul 14 2026 at 21:24, Haofeng Li wrote:
> -	iounmap(regs);
> +	/* Only OF path uses of_iomap(); ACPI/platform uses devm mapping. */

Instead of this comment and conditional unmap the OF specific map side
should just use devm_of_iomap(), no?

> +	if (is_of_node(fwnode))
> +		iounmap(regs);
>  	return error;
>  }

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.