[PATCH v2 0/2] phy: spacemit: fix and enable the K1 USB 2.0 PHY
Bruno Banelli <[email protected]>
| Newsgroups | org.infradead.lists.linux-riscv,dev.linux.lists.spacemit,org.infradead.lists.linux-phy,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
v1 was a single patch adding "default ARCH_SPACEMIT" to PHY_SPACEMIT_K1_USB2. Automated review pointed out two pre-existing Kconfig problems in the same entry, and that change makes them easier to hit: enabling the symbol by default means configurations that would previously have left it off will now build the driver. So fix the dependencies first, then enable it by default. Both were verified against the driver source: phy-k1-usb2.c calls devm_platform_ioremap_resource() and devm_regmap_init_mmio(), while the Kconfig entry has neither "depends on HAS_IOMEM" nor "select REGMAP_MMIO". PHY_SPACEMIT_K1_PCIE, directly above it in the same file, already has the HAS_IOMEM dependency. Tested on a Milk-V Jupiter (SpacemiT M1) running mainline 7.2: without patch 2/2 a "make defconfig" kernel has no USB at all, because dwc3-generic-plat cannot get its PHY. v1: https://lore.kernel.org/linux-riscv/[email protected]/ Changes in v2: - new patch 1/2 adding "depends on HAS_IOMEM" and "select REGMAP_MMIO", with a Fixes: tag - no change to the patch now numbered 2/2 Bruno Banelli (2): phy: spacemit: fix K1 USB 2.0 PHY Kconfig dependencies phy: spacemit: enable K1 USB 2.0 PHY by default on ARCH_SPACEMIT drivers/phy/spacemit/Kconfig | 3 +++ 1 file changed, 3 insertions(+) base-commit: 66498c75b4f8017f62d720d9b59675bdf3abce91 -- 2.43.0 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv