Re: [PATCH] phy: spacemit: enable K1 USB 2.0 PHY by default on ARCH_SPACEMIT
Yixun Lan <[email protected]>
| Newsgroups | org.infradead.lists.linux-riscv,dev.linux.lists.spacemit,org.infradead.lists.linux-phy,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi Bruno, On 07:21 Tue 25 Aug , Bruno Banelli wrote: > PHY_SPACEMIT_K1_PCIE has "default ARCH_SPACEMIT", but > PHY_SPACEMIT_K1_USB2, twelve lines below it in the same file, does not. > Since the symbol is also absent from arch/riscv/configs/defconfig, a > plain "make defconfig" build for a SpacemiT K1 board ends up with the > USB 2.0 PHY driver disabled. > > dwc3-generic-plat needs that PHY, so the result is a kernel with no > working USB at all on boards such as the Milk-V Jupiter, where all four > USB 3.0 type-A ports hang off the single dwc3 controller. > > Give it the same default as its sibling. > > Signed-off-by: Bruno Banelli <[email protected]> Looks good to me Reviewed-by: Yixun Lan <[email protected]> -- Yixun Lan (dlan) _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv