Re: [PATCH] riscv: defconfig: enable dwc3 and the SpacemiT K1 thermal sensor
Conor Dooley <[email protected]>
| Newsgroups | org.infradead.lists.linux-riscv,dev.linux.lists.spacemit,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260826-ought-tableware-73678af4dd1f@spud> |
On Tue, Aug 25, 2026 at 10:49:05PM +0000, Yixun Lan wrote: > Hi Bruno, > > On 07:22 Tue 25 Aug , Bruno Banelli wrote: > > Two blocks on SpacemiT K1 boards are unreachable from a stock defconfig > > build: > > > > - USB_DWC3 is not enabled, so the dwc3 controller that drives all of > > the USB 3.0 ports on boards like the Milk-V Jupiter never probes. > > > > - SPACEMIT_K1_TSENSOR has no default in its Kconfig and is not listed > > here, so a K1 board comes up with no temperature readings at all, > > even though k1.dtsi describes five thermal zones. > > > > Enable both. > > > The patch itself looks good to me, but since it deal with two diferent drivers > So, can you split it into two patches? which easy to review and manage IMO it's fine being one patch, but this temp sensor should probably be a module? > > > Signed-off-by: Bruno Banelli <[email protected]> > > --- > > arch/riscv/configs/defconfig | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig > > index 04ae305d5..03d9ac2f7 100644 > > --- a/arch/riscv/configs/defconfig > > +++ b/arch/riscv/configs/defconfig > > @@ -209,6 +209,8 @@ CONFIG_USB=y > > CONFIG_USB_OTG=y > > CONFIG_USB_XHCI_HCD=y > > CONFIG_USB_XHCI_PLATFORM=y > > +CONFIG_USB_DWC3=y > > +CONFIG_USB_DWC3_GENERIC_PLAT=y > > CONFIG_USB_EHCI_HCD=y > > CONFIG_USB_EHCI_HCD_PLATFORM=y > > CONFIG_USB_OHCI_HCD=y > > @@ -260,6 +262,7 @@ CONFIG_CLK_SOPHGO_SG2042_PLL=y > > CONFIG_CLK_SOPHGO_SG2042_CLKGEN=y > > CONFIG_CLK_SOPHGO_SG2042_RPGATE=y > > CONFIG_SPACEMIT_K1_CCU=y > > +CONFIG_SPACEMIT_K1_TSENSOR=y > > CONFIG_SPACEMIT_K3_CCU=y > > CONFIG_SUN8I_DE2_CCU=m > > CONFIG_SUN50I_IOMMU=y > > > > base-commit: 66498c75b4f8017f62d720d9b59675bdf3abce91 > > -- > > 2.43.0 > > > > -- > Yixun Lan (dlan) _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
signature.asc
(application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCao6kxgAKCRB4tDGHoIJi 0v5VAQDYT8jhm+YKA8FT1Q7h0iuPmAOmrpY0WCsMjmlbUFM3SgD+NRQmA/aRKSzC oKHb76m702nIoXoRdTDuwGBv8GgNbgE= =XCwW -----END PGP SIGNATURE-----