Re: [PATCH v3 6/6] riscv: dts: spacemit: Add CTF2301 on K3 CoM260

On Mon, Aug 10, 2026 at 04:20:05PM +0800, Troy Mitchell wrote:
> My intention here was to keep all board-specific pin configuration
> overrides under a single &pinctrl block, so that they can be found and
> maintained in one place. Using a separate top-level reference for each pin
> group would tend to scatter those overrides throughout the board DTS as
> more groups are customized. The &pinctrl block is also placed immediately
> before the &i2c6 consumer.
>
> Would keeping the current structure be acceptable for that reason? If you
> still prefer the direct reference, I will change it to &i2c6_1_cfg in the
> next revision.

I withdraw my earlier suggestion to keep all board-specific pin
configuration overrides under a single &pinctrl block.

After checking existing board DTS files, I found that the direct-reference
style is already in use. For example:

  arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts

adds the board-specific bias-pull-up setting directly through &i2c1_pins.
Likewise:

  arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi

extends &mmc0_pins directly.

Both forms produce the same node override, but since the reference-based
form is already used in the tree, we should follow it instead of introducing
a different structure here. I will change the board-level override to
&i2c6_1_cfg in the next version.

                                            - Troy

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

-----BEGIN PGP SIGNATURE-----

iJcEABYKAD8WIQSL4Ay2cExaPXAQcU2YCe+A+TM0LwUCao/btSEcdHJveS5taXRj
aGVsbEBsaW51eC5zcGFjZW1pdC5jb20ACgkQmAnvgPkzNC/6QAEA8dCtfup87U2o
snvjwoIwNCa2Z99Am38hnnyreNWzGecA/03n71wIE+T3csVbRbAT21+VwQ2RuK80
7pZ57h/HWuEH
=bLKp
-----END PGP SIGNATURE-----