Re: [PATCH v6 03/21] dt-bindings: pinctrl: Add starfive,jhb100-sys0-pinctrl
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.infradead.lists.linux-riscv,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 30/08/2026 03:29, Changhuang Liang wrote: > Hi, Krzysztof > > Thanks for the review. > >> On 29/08/2026 04:57, Changhuang Liang wrote: >>> +#ifndef __DT_BINDINGS_PINCTRL_STARFIVE_JHB100_H__ >>> +#define __DT_BINDINGS_PINCTRL_STARFIVE_JHB100_H__ >>> + >>> +/* sys0 pad numbers */ >>> +#define PADNUM_SYS0_GPIO_A0 0 >>> +#define PADNUM_SYS0_GPIO_A1 1 >>> +#define PADNUM_SYS0_GPIO_A2 2 >>> +#define PADNUM_SYS0_GPIO_A3 3 >> >> I could not find how your driver uses these, so are you sure it's a binding >> constant for the SW? > > Yes, these are not used in the driver, but in PATCH 6/8/10/12, etc., some definitions > for other GPIOs are still used. Therefore, I have uniformly defined them in the > binding, and they will be provided to the device tree for use later. I am confused. The driver in these patches 6/8/10/12 does include the header but does not use them. Why do you include unused headers? Or what is exactly the use? Best regards, Krzysztof _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv