Re: [PATCH v4 5/8] phy: rockchip: samsung-hdptx: Drop TMDS rate setup workaround
Cristian Ciocaltea <[email protected]>
| Newsgroups | org.infradead.lists.linux-rockchip,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-phy,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi Andy,
On 7/23/26 2:51 PM, Andy Yan wrote:
> Hello,
>
> On 6/12/26 07:45, Cristian Ciocaltea wrote:
>> Since commit ba9c2fe18c17 ("drm/rockchip: dw_hdmi_qp: Switch to
>> phy_configure()") the TMDS rate setup doesn't rely anymore on the
>> unconventional usage of the bus width, instead it is managed exclusively
>> through the HDMI PHY configuration API.
>>
>> Drop the now obsolete workaround to retrieve the TMDS character rate via
>> phy_get_bus_width() during power_on().
>>
>> While at it, get rid of the extra call to rk_hdptx_phy_consumer_put() by
>> moving the statement at the end of the function.
>>
>> Tested-by: Thomas Niederprüm <[email protected]>
>> Tested-by: Simon Wright <[email protected]>
>> Signed-off-by: Cristian Ciocaltea <[email protected]>
>
> Reviewed-by: Andy Yan <[email protected]>
Dmitry suggested moving the code cleanup around rk_hdptx_phy_consumer_put() into
a separate commit, so I'll handle it in v5, which I'll send later today. Since
this has no functional implications, I'll retain your R-b for the updated patch.
Thanks for reviewing the series!
Cristian
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip