Re: [PATCH net-next 0/3] net: stmmac: dwmac-rk: add RK3576 GMAC 25M refout support

Hi Gavin,

We ran into the same thing on the ArmSoM CM5-IO. As Alexey and Maxime
say, the 25 MHz output is a CRU clock muxed to a pin, so the PHY should
enable it, not the GMAC. I sent that for the YT8531:

  https://lore.kernel.org/all/[email protected]/

It has Andrew's Reviewed-by and is waiting for net-next. On the CM5-IO
the YT8531 comes up at 1000 Mbit/s with no dwmac-rk change and no dwmac
binding change.

Your board has a YT8521, which uses yt8521_probe(), so it needs the same
devm_clk_get_optional_enabled() there rather than in yt8531_probe(). I am
happy to fold YT8521 into my patch, or you can send a small follow-up
once mine lands, whichever the maintainers prefer. The board DTS then
just needs a clocks phandle to the CRU on the PHY node.

Thanks,
Jiaxing

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip