[PATCH 0/2] mailbox: rockchip: fix the pclk lifetime
Linmao Li <[email protected]>
| Newsgroups | org.infradead.lists.linux-rockchip,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
The Rockchip mailbox driver enables its peripheral clock in probe() and
never disables it: neither on the failure paths that follow, nor when the
device is unbound, since the driver has no remove callback.
Patch 1 fixes that with devm_clk_get_enabled(). It stands on its own and
is the only one relevant for stable.
Patch 2 is a follow-up cleanup. The pclk pointer is only used in probe(),
so it can be made local and dropped from the driver data. This mirrors
commit 6b0eadf69bd1 ("mailbox: exynos: drop unneeded runtime pointer
(pclk)").
Compile-tested on linux-next with CONFIG_ROCKCHIP_MBOX=y; both patches
build cleanly with W=1. Not tested on hardware.
Linmao Li (2):
mailbox: rockchip: disable pclk on probe failure and unbind
mailbox: rockchip: drop unneeded runtime pointer (pclk)
drivers/mailbox/rockchip-mailbox.c | 19 +++++--------------
1 file changed, 5 insertions(+), 14 deletions(-)
base-commit: c5e32e86ca02b003f86e095d379b38148999293d
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip