Re: [PATCH net-next v2] net: phy: motorcomm: enable the reference clock for YT8521 and YT8531
Jiaxing Hu <[email protected]>
| Newsgroups | org.infradead.lists.linux-rockchip,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
> Look around at other drivers. Is it generally put into a tiny helper, > or used inline? > > My gut feeling from reviewing lots of drivers is that it is inline. Agreed. v3 open-codes the get-and-enable in both yt8521_probe and yt8531_probe, with no helper. I had already sent it before this mail: https://lore.kernel.org/all/[email protected]/ It carries your Reviewed-by and Gavin's Tested-by. Jiaxing _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip