Re: [PATCH v3 4/4] media: qcom: camss: use fwnode_graph_for_each_endpoint_scoped() to simplify code
Bryan O'Donoghue <[email protected]>
| Newsgroups | org.infradead.lists.linux-rockchip,dev.linux.lists.driver-core,dev.linux.lists.imx,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-acpi,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media |
|---|---|
| Message-ID | <[email protected]> |
On 25/06/2026 15:17, [email protected] wrote: > From: Frank Li <[email protected]> > > Use fwnode_graph_for_each_endpoint_scoped() to simplify code. > > No functional changes. > > Reviewed-by: Guoniu Zhou <[email protected]> > Reviewed-by: Loic Poulain <[email protected]> > Reviewed-by: Andy Shevchenko <[email protected]> > Reviewed-by: Laurent Pinchart <[email protected]> > Signed-off-by: Frank Li <[email protected]> > --- > change in v2 > - fix typo simplify > - collect andy, gouniou and loic's review tags > --- > drivers/media/platform/qcom/camss/camss.c | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c > index 2123f6388e3d7..23f3cc30a15a5 100644 > --- a/drivers/media/platform/qcom/camss/camss.c > +++ b/drivers/media/platform/qcom/camss/camss.c > @@ -4793,30 +4793,23 @@ static int camss_parse_endpoint_node(struct device *dev, > static int camss_parse_ports(struct camss *camss) > { > struct device *dev = camss->dev; > - struct fwnode_handle *fwnode = dev_fwnode(dev), *ep; > + struct fwnode_handle *fwnode = dev_fwnode(dev); > int ret; > > - fwnode_graph_for_each_endpoint(fwnode, ep) { > + fwnode_graph_for_each_endpoint_scoped(fwnode, ep) { > struct camss_async_subdev *csd; > > csd = v4l2_async_nf_add_fwnode_remote(&camss->notifier, ep, > typeof(*csd)); > - if (IS_ERR(csd)) { > - ret = PTR_ERR(csd); > - goto err_cleanup; > - } > + if (IS_ERR(csd)) > + return PTR_ERR(csd); > > ret = camss_parse_endpoint_node(dev, ep, csd); > if (ret < 0) > - goto err_cleanup; > + return ret; > } > > return 0; > - > -err_cleanup: > - fwnode_handle_put(ep); > - > - return ret; > } > > /* > Acked-by: Bryan O'Donoghue <[email protected]> _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip