Re: (subset) [PATCH V10 0/4] Add Anbernic RG Vita-Pro
Heiko Stuebner <[email protected]>
| Newsgroups | org.infradead.lists.linux-rockchip,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 28 Jul 2026 15:38:28 -0500, Chris Morgan wrote: > Add support for the Anbernic RG Vita-Pro, based on the Rockchip RK3576 SoC. > > Changes Since V1: > - Updated documentation filename to matche compatible string. > - Corrected order of allocating IRQ in charger driver and switched > to using devm managed function to allocate work queue. > Changes Since V2: > - Corrected issue with naming of panel binding document and added > fallback compatible string. > - Switched to devm helpers in panel driver. Note that > devm_drm_panel_add() is currently only in the drm-next branch. > - Optimized setting GPIOs for panel driver. > Changes Since V3: > - Fixed numerous issues identifed by Sashiko bot, mainly relating > to unclamped or improperly clamped values from within the > charger driver. > - Corrected hard-coded values in the panel driver unprepare routine > as well as correcting an improperly checked return condition. > Changes Since V4: > - Fixed errors identified by Sashiko bot on charger driver that could > result in an improper value being written to the registers. > - Corrected some error handling in the panel driver. > Changes Since V5: > - Corrected minor errors in documentation and added default values. > - Further corrected clamping behavior in charger driver. > Changes Since V6: > - Additional corrections as suggested by Sashiko bot to fix potential > edge cases during probe for sgm41542. > - Corrected an improperly shifted value being written to register for > sgm41542. > - Changed a MV value to UV in sgm41542 driver to simplify function. > Changes Since V7: > - Added PM functions to sgm41542 driver per request from Sashiko, > which stops the hardware watchdog during suspend. > - Switched from device_init_wakeup() to devm_device_init_wakeup(). > - Confirmed a state change in IRQ handler for sgm41542 to ensure we > don't update input current limit except when the vbus goes from > not okay to okay. > - Removed panel patches, which have already been accepted upstream. > Please note that this *may* cause an error about missing bindings. > See commit 0fd6ead8270270d859a28d0196a4b47e7d6845b8 in linux-next. > Changes Since V8: > - Added linux/bitfield.h header to prevent compile errors on certain > platforms. > - Added regulator to Kconfig as a dependency. > - Added mutex to IRQ handling function. > - Added update to watchdog enable field in suspend routine to ensure > watchdog status "goes back to the way it was" after resume. > - Sashiko complains of an issue if userspace updates values after > devm_power_supply_register() is called but before the hardware > limits are set from the device tree. While this is possible the > threat of a problem should be very low given that the hardware > limits are set immediately afterward and would overwrite any > wrong values from userspace (should happen within a few > milliseconds). Unfortunately, given that the function to get these > limits requires the power supply be registered in order to read > the battery node, it's not something that can be easily fixed at > this time. Since it's an *extremely* unlikely edge case, I think > that's acceptable. > Changes Since V9: > - Made a few minor tweaks as suggested by sashiko.dev. > - Adopted new init function for __power_supply_register() so that I > can have the proper min and max values from the firmware prior to > exposing the charger to userspace. New init function is part of > this series here: https://lore.kernel.org/all/[email protected]/ > > [...] Applied, thanks! [3/4] dt-bindings: arm: rockchip: Add Anbernic RG Vita-Pro commit: 74aab5a3042e56681eb8170bad84789fb42eae60 [4/4] arm64: dts: rockchip: Add Anbernic RG Vita-Pro commit: aaed846aa94076aa670c60089a7143a0f43327b4 Best regards, -- Heiko Stuebner <[email protected]> _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip