Re: [PATCH v3] media: hantro: release runtime resources when device_run fails

Hi Tharit,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on pza/reset/next v7.2-rc5 next-20260729]
[cannot apply to pza/imx-drm/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Tharit-Tangkijwanichakul/media-hantro-release-runtime-resources-when-device_run-fails/20260726-104549
base:   linus/master
patch link:    https://lore.kernel.org/r/20260726024243.730-1-tharitt97%40gmail.com
patch subject: [PATCH v3] media: hantro: release runtime resources when device_run fails
config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20260730/[email protected]/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260730/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

>> drivers/media/platform/verisilicon/hantro_drv.c:1309:12: warning: 'hantro_runtime_suspend' defined but not used [-Wunused-function]
    1309 | static int hantro_runtime_suspend(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/verisilicon/hantro_drv.c:1287:12: warning: 'hantro_runtime_resume' defined but not used [-Wunused-function]
    1287 | static int hantro_runtime_resume(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~


vim +/hantro_runtime_suspend +1309 drivers/media/platform/verisilicon/hantro_drv.c

  1286	
> 1287	static int hantro_runtime_resume(struct device *dev)
  1288	{
  1289		struct hantro_dev *vpu = dev_get_drvdata(dev);
  1290		int ret;
  1291	
  1292		ret = clk_bulk_enable(vpu->variant->num_clocks, vpu->clocks);
  1293		if (ret)
  1294			return ret;
  1295	
  1296		if (vpu->variant->runtime_resume) {
  1297			ret = vpu->variant->runtime_resume(vpu);
  1298			if (ret)
  1299				goto err_disable_clocks;
  1300		}
  1301	
  1302		return 0;
  1303	
  1304	err_disable_clocks:
  1305		clk_bulk_disable(vpu->variant->num_clocks, vpu->clocks);
  1306		return ret;
  1307	}
  1308	
> 1309	static int hantro_runtime_suspend(struct device *dev)
  1310	{
  1311		struct hantro_dev *vpu = dev_get_drvdata(dev);
  1312	
  1313		clk_bulk_disable(vpu->variant->num_clocks, vpu->clocks);
  1314		return 0;
  1315	}
  1316	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip