Re: [PATCH net-next 2/3] arm64: dts: rockchip: Add RK3576 GMAC 25M refout clocks

Krzysztof Kozlowski <[email protected]> Thu, 30 Jul 2026 10:28:10 +0200

Newsgroups	org.infradead.lists.linux-rockchip,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID	<20260730-complex-funky-angelfish-dc9aad@quoll>

On Mon, Jul 27, 2026 at 10:10:46AM +0800, Gavin Gao wrote:
> RK3576 provides REFCLKO25M_GMAC0_OUT and REFCLKO25M_GMAC1_OUT clocks
> for the two GMAC instances.
> 
> Describe these clocks with the clk_mac_25m_refout clock name so boards
> using RGMII output clock mode can let the MAC driver manage the 25 MHz
> reference output.
> 
> Signed-off-by: Gavin Gao <[email protected]>
> ---
>  arch/arm64/boot/dts/rockchip/rk3576.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> index 70e67d4dccb8..f1125c2f88ab 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> @@ -1692,10 +1692,10 @@ gmac0: ethernet@2a220000 {
>  			reg = <0x0 0x2a220000 0x0 0x10000>;
>  			clocks = <&cru CLK_GMAC0_125M_SRC>, <&cru CLK_GMAC0_RMII_CRU>,
>  				 <&cru PCLK_GMAC0>, <&cru ACLK_GMAC0>,
> -				 <&cru CLK_GMAC0_PTP_REF>;
> +				 <&cru CLK_GMAC0_PTP_REF>, <&cru REFCLKO25M_GMAC0_OUT>;
>  			clock-names = "stmmaceth", "clk_mac_ref",
>  				      "pclk_mac", "aclk_mac",
> -				      "ptp_ref";
> +				      "ptp_ref", "clk_mac_25m_refout";

Where is clk_mac_refout? Why do you claim this is a different input
(important: INPUT)?

Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip