Re: [PATCH net-next 1/3] dt-bindings: net: rockchip-dwmac: Add 25M refout clock

On Thu, Jul 30, 2026 at 4:27 PM Krzysztof Kozlowski <[email protected]> wrote:
>
> On Mon, Jul 27, 2026 at 10:10:45AM +0800, Gavin Gao wrote:
> > Some Rockchip GMAC instances can provide a 25 MHz reference clock output
> > for an external RGMII PHY.
> >
> > Add a clock name for this 25 MHz reference output so SoC dtsi files can
> > describe it separately from the existing MAC reference clocks.
> >
> > Signed-off-by: Gavin Gao <[email protected]>
> > ---
> >  Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> > index 0ac7c4b47d6b..074ac274f2e0 100644
> > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> > @@ -81,6 +81,7 @@ properties:
> >          - pclk_mac
> >          - clk_mac_ref
> >          - clk_mac_refout
> > +        - clk_mac_25m_refout
>
> That's the same as clk_mac_ref and clk_mac_refout. clocks are not
> outputs but inputs, so explain how does the device take three SAME
> clocks: clk_mac_ref, clk_mac_refout and clk_mac_25m_refout?
>
> Best regards,
> Krzysztof
>

This is not the existing clk_mac_refout clock. On RK3576 the
REFCLKO25M_GMAC[01]_OUT clocks are separate 25 MHz reference clock outputs
intended for RGMII PHYs, while clk_mac_refout is the existing refout clock
used by the Rockchip DWMAC binding for the RMII reference output path.

-- 
Best Regards,
Gavin Gao

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip