Re: [PATCH v3 1/4] pinctrl: rockchip: Decode drive strength in the get function
Linus Walleij <[email protected]>
| Newsgroups | org.infradead.lists.linux-rockchip,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAD++jL=hGH7a-LM+Foy=mVxmVhCdtaxdaF5Mfo+3BCwMLHNVdQ@mail.gmail.com> |
On Wed, Jul 29, 2026 at 3:30 PM Simon Glass <[email protected]> wrote: > The decoding of the 2-bit and 8-bit level drive-strength values sits in > rockchip_set_drive_perpin(), where it is unreachable: the SoCs whose > banks declare these drive types (RK3506 and RV1103B) take the early > ctrl->type branch in the set path, and the read-and-decode logic in a > set function has no purpose. Meanwhile rockchip_get_drive_perpin() > lacks the decoding, so pin_config_get() and the debugfs output report > -EINVAL for these SoCs. > > Move the two cases to rockchip_get_drive_perpin(), where they belong. > > Fixes: dbd2317d7b9f ("pinctrl: rockchip: Add rk3506 pinctrl support") > Signed-off-by: Simon Glass <[email protected]> Patch applied! Yours, Linus Walleij _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip