Re: [PATCH] dt-bindings: iio: adc: rockchip-saradc: Fix RV1106 compatible
Joshua Crofts <[email protected]>
| Newsgroups | org.infradead.lists.linux-rockchip,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Sun, 16 Aug 2026 14:36:36 +0300 Vladislav Leonov <[email protected]> wrote: > rockchip,rv1106-saradc was folded into the fallback enum together > with rockchip,rk3576-saradc, falling back to rockchip,rk3588-saradc. > The two IP blocks are not equivalent, though: per the RV1106 TRM v0.3, > chapter 20 (SAR-ADC), RV1106 only has 2 channels at 10-bit resolution, > versus 8 channels at 12-bit on RK3588. Documenting it as falling back > to rk3588-saradc allows device trees that would bind against the wrong > channel table and report an incorrect voltage scale. > > Remove rockchip,rv1106-saradc from the RK3588 fallback enum and give > it its own standalone compatible entry, matching the dedicated match > table entry added by the driver patch. > > Fixes: bdba14f6122c ("dt-bindings: iio: adc: rockchip-saradc: Add RV1106 compatible") > Link: https://lore.kernel.org/all/[email protected] > Signed-off-by: Vladislav Leonov <[email protected]> > --- Looking at the link provided, it seems that there should be a Suggested-by tag for Jonathan? Otherwise LGTM Reviewed-by: Joshua Crofts <[email protected]> -- Kind regards, Joshua Crofts _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip