Re: [PATCH v8 04/12] dt-bindings: npu: rockchip: add rockchip,rk3576-rknn-core
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.infradead.lists.linux-rockchip,dev.linux.lists.iommu,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <[email protected]> |
On 19/08/2026 01:09, Rob Herring (Arm) wrote: > > On Mon, 17 Aug 2026 23:35:55 +1200, Jiaxing Hu wrote: >> The RK3576 NPU has two cores of the same RKNN block the RK3588 binding >> already describes, but it wires them up differently: two extra CBUF >> clocks, two power domains per core, and a single reset instead of two. >> It also has no NPU SRAM supply. >> >> Widen the property ranges to cover both, then pin each SoC back to its >> own shape in allOf so nothing loosens for RK3588, and keep sram-supply >> required for rockchip,rk3588-rknn-core only. >> >> Signed-off-by: Jiaxing Hu <[email protected]> >> Reviewed-by: Krzysztof Kozlowski <[email protected]> >> --- >> .../npu/rockchip,rk3588-rknn-core.yaml | 47 +++++++++++++++++-- >> 1 file changed, 44 insertions(+), 3 deletions(-) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml: Unresolvable reference: /schemas/input/qcom,spmi-haptics.yaml# > > doc reference errors (make refcheckdocs): > Documentation/translations/pt_BR/process/security-bugs.rst: :doc:`regular path submission </../../../process/submitting-patches>` > Documentation/translations/zh_CN/how-to.rst: Documentation/translations/zh_CN/xxx.rst > arch/arm/xen/enlighten.c: Documentation/devicetree/bindings/arm/xen.txt Most likely false positive due to other things in the kernel broken. But just in case - be sure you tested the bindings. Best regards, Krzysztof _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip