Re: [PATCH v7 3/5] drm/bridge: analogix_dp: Restore mandatory samsung DP DT properties
Damon Ding <[email protected]>
| Newsgroups | org.infradead.lists.linux-rockchip,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi Luca,
On 8/19/2026 8:54 PM, Luca Ceresoli wrote:
>> Revert the change that made samsung,link-rate and samsung,lane-count
>> optional for Exynos DP. Add error checking to fail probe early if the
>> required DT properties are missing.
>>
>> If these properties are zero, &link_train.link_rate and
>> &link_train.lane_count used in the subsequent link training flow will
>> also be zero, resulting in link training failure. Although all existing
>> Exynos DP DT nodes already contain these two properties, this potential
>> logic issue still needs to be fixed.
>>
>> Fixes: 0d0abd894ead ("drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288")
>
> If it's a fix, please add 'Cc: stable' too.
>
> Also please add to the commit message the detailed analysis you wrote in
> the v6 discussion, so that it will easy to find in the git history, in case
> it's needed in the future.
>
> With that added you can add: Reviewed-by: Luca Ceresoli <[email protected]>
>
>
Yes, will do in v8.
Best regards,
Damon
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip