Re: [PATCH 1/5] ARC: uapi: Stop leaking CONFIG_ARC_HAS_SWAPE reference to userspace
"Arnd Bergmann" <[email protected]>
| Newsgroups | org.infradead.lists.linux-snps-arc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Dec 30, 2025, at 08:10, Thomas Weißschuh wrote: > UAPI headers are not supposed to leak references to kconfig symbols. > These won't be set when building userspace. Hide the kconfig reference > behind 'if defined(__KERNEL__)', so it will be stripped by > headers_install.sh. The result for userspace will be the same, but the > exception in headers_install.sh can also be removed. > > Signed-off-by: Thomas Weißschuh <[email protected]> Acked-by: Arnd Bergmann <[email protected]> Same as for the nios2 version, I think the nicer solution would be to use the asm-generic header for uapi and move this one to arch/arc/include/asm/swab.h for kernel-internal use. In theory, using 'select ARCH_USE_BUILTIN_BSWAP' in Kconfig should let the compiler pick the best swap instruction, which would be even less code, but I'm not sure if there was a reason that nios2 and arc don't already do this. Arnd _______________________________________________ linux-snps-arc mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-snps-arc