Re: [PATCH] sbi_mpxy: Add Logging service group handlers

On Tue, Jun 9, 2026 at 11:29 AM Subrahmanya Lingappa
<[email protected]> wrote:
>
Missing commit message

> Signed-off-by: Subrahmanya Lingappa <[email protected]>
> ---
>  include/sbi_utils/mailbox/rpmi_msgprot.h | 19 ++++++++++
>  lib/utils/mpxy/Kconfig                   |  4 +++
>  lib/utils/mpxy/fdt_mpxy_rpmi_logging.c   | 44 ++++++++++++++++++++++++
>  lib/utils/mpxy/objects.mk                |  3 ++
>  platform/generic/configs/defconfig       |  1 +
>  5 files changed, 71 insertions(+)
>  create mode 100644 lib/utils/mpxy/fdt_mpxy_rpmi_logging.c
>
> diff --git a/include/sbi_utils/mailbox/rpmi_msgprot.h b/include/sbi_utils/mailbox/rpmi_msgprot.h
> index 4fec6402..b034b9b7 100644
> --- a/include/sbi_utils/mailbox/rpmi_msgprot.h
> +++ b/include/sbi_utils/mailbox/rpmi_msgprot.h
> @@ -221,6 +221,7 @@ enum rpmi_servicegroup_id {
>         RPMI_SRVGRP_DEVICE_POWER = 0x0009,
>         RPMI_SRVGRP_PERFORMANCE = 0x0000A,
>         RPMI_SRVGRP_MANAGEMENT_MODE = 0x000B,
> +       RPMI_SRVGRP_LOGGING = 0x000E,
>         RPMI_SRVGRP_ID_MAX_COUNT,
>
>         /* Reserved range for service groups */
> @@ -1032,4 +1033,22 @@ struct rpmi_ras_sync_err_resp {
>         u32 pending_vecs[MAX_PEND_VECS];
>  };
>
> +/** RPMI LOGGING ServiceGroup Service IDs */
> +enum rpmi_logging_service_id {
> +       RPMI_LOGGING_SRV_ENABLE_NOTIFICATION = 0x01,
> +       RPMI_LOGGING_SRV_SET_CONFIG = 0x02,

RPMI spec mentions this service as "LOG_DATA". The used name here should
not completely differ from what spec uses as the name of the service.


> +       RPMI_LOGGING_SRV_MAX_COUNT,
> +};
> +
> +struct rpmi_logging_set_config_req {

Wrt to the name of the service these structures' names
should also change.

> +       u32 type;
> +       u32 len;
> +#define MAX_LOGGING_DLEN  ((RPMI_MSG_DATA_SIZE(RPMI_SLOT_SIZE_MIN) - (sizeof(u32) * 2)) / sizeof(u32))
> +       u32 data[MAX_LOGGING_DLEN];
> +};
> +
> +struct rpmi_logging_set_config_resp {
> +       s32 status;
> +};
> +
>  #endif /* !__RPMI_MSGPROT_H__ */

-- 
opensbi mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/opensbi