Re: [PATCH] firmware: Fix comment after relocation completion

On Fri, Jun 26, 2026 at 7:56 AM Zong Li <[email protected]> wrote:
>
> After relocation is done, the code is running from the load address,
> not the link address. Fix the comment to correctly reflect this.
>
> Signed-off-by: Zong Li <[email protected]>

LGTM.

Reviewed-by: Anup Patel <[email protected]>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

> ---
>  firmware/fw_base.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/firmware/fw_base.S b/firmware/fw_base.S
> index 5d6540d7..0c5c65c1 100644
> --- a/firmware/fw_base.S
> +++ b/firmware/fw_base.S
> @@ -93,7 +93,7 @@ _sc_fail:
>         addi    t0, t0, (__SIZEOF_LONG__ * 3)
>         blt     t0, t1, 2b
>  _relocate_done:
> -       /* At this point we are running from link address */
> +       /* At this point we are running from load address */
>
>         /* Reset all registers except ra, a0, a1, a2, a3 and a4 for boot HART */
>         li      ra, 0
> --
> 2.43.7
>
>
> --
> opensbi mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/opensbi

-- 
opensbi mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/opensbi