Re: [PATCH 04/18] dbtr: Return correct error on install not supported

On Fri, Mar 13, 2026 at 03:19:33PM +1000, Nicholas Piggin wrote:
> Return SBI_ERR_NOT_SUPPORTED if a trigger is valid but not
> supported.
> 
> Signed-off-by: Nicholas Piggin <[email protected]>
> ---
>  lib/sbi/sbi_dbtr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/sbi/sbi_dbtr.c b/lib/sbi/sbi_dbtr.c
> index 10ed6b3e..65c3b2df 100644
> --- a/lib/sbi/sbi_dbtr.c
> +++ b/lib/sbi/sbi_dbtr.c
> @@ -617,7 +617,7 @@ int sbi_dbtr_install_trig(unsigned long smode,
>  			*out = _idx;
>  			sbi_hart_protection_unmap_range((unsigned long)shmem_base,
>  							trig_count * sizeof(*entry));
> -			return SBI_ERR_FAILED;
> +			return SBI_ERR_NOT_SUPPORTED;
>  		}
>

Looks good.

Reviewed-by: Himanshu Chauhan <[email protected]>

Thanks
Himanshu

>  		if (!dbtr_trigger_valid(TDATA1_GET_TYPE(tdata1), tdata1)) {
> -- 
> 2.51.0
> 
> 
> -- 
> opensbi mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/opensbi

-- 
opensbi mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/opensbi