Re: [PATCH] lib: utils/reset: Remove unused match data

On Thu, May 14, 2026 at 4:14 AM Samuel Holland
<[email protected]> wrote:
>
> Some drivers inherited FDT match data from the GPIO/syscon reset
> drivers, but do not use it for anything. Remove it to avoid confusion.
>
> Signed-off-by: Samuel Holland <[email protected]>

LGTM.

Reviewed-by: Anup Patel <[email protected]>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

> ---
>
>  lib/utils/reset/fdt_reset_sg2042_hwmon_mcu.c | 2 +-
>  lib/utils/reset/fdt_reset_spacemit_p1.c      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/utils/reset/fdt_reset_sg2042_hwmon_mcu.c b/lib/utils/reset/fdt_reset_sg2042_hwmon_mcu.c
> index 94ac4162..bb180268 100644
> --- a/lib/utils/reset/fdt_reset_sg2042_hwmon_mcu.c
> +++ b/lib/utils/reset/fdt_reset_sg2042_hwmon_mcu.c
> @@ -104,7 +104,7 @@ static int sg2042_mcu_reset_init(const void *fdt, int nodeoff,
>  }
>
>  static const struct fdt_match sg2042_mcu_reset_match[] = {
> -       { .compatible = "sophgo,sg2042-hwmon-mcu", .data = (void *)true},
> +       { .compatible = "sophgo,sg2042-hwmon-mcu" },
>         { },
>  };
>
> diff --git a/lib/utils/reset/fdt_reset_spacemit_p1.c b/lib/utils/reset/fdt_reset_spacemit_p1.c
> index 5312e741..d153f68b 100644
> --- a/lib/utils/reset/fdt_reset_spacemit_p1.c
> +++ b/lib/utils/reset/fdt_reset_spacemit_p1.c
> @@ -102,7 +102,7 @@ static int p1_reset_init(const void *fdt, int nodeoff,
>  }
>
>  static const struct fdt_match p1_reset_match[] = {
> -       { .compatible = "spacemit,p1", .data = (void *)true },
> +       { .compatible = "spacemit,p1" },
>         { },
>  };
>
> --
> 2.52.0
>
> base-commit: 79e63bc8348df12835b5c264144e50d45abe72c8
> branch: up/cleanup-reset
>
> --
> opensbi mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/opensbi

-- 
opensbi mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/opensbi