[PATCH 2/2] iio: gyro: hid-sensor-gyro-3d: Use dev_err_probe()
Sanjay Chitroda <[email protected]>
| Newsgroups | org.kernel.feeds.b4-sent,org.kernel.vger.linux-iio,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260724-24-july-hid-gyro-dev-log-clenaup-v1-2-0c932b77104a@gmail.com> |
Replace dev_err() calls with dev_err_probe() during probe. dev_err_probe() makes error code handling simpler and handle deferred probe nicely (avoid spamming logs). Signed-off-by: Sanjay Chitroda <[email protected]> --- drivers/iio/gyro/hid-sensor-gyro-3d.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c index bcf53e267701..48540c9a097c 100644 --- a/drivers/iio/gyro/hid-sensor-gyro-3d.c +++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c @@ -264,13 +264,14 @@ static int gyro_3d_parse_report(struct platform_device *pdev, /* Function to initialize the processing for usage id */ static int hid_gyro_3d_probe(struct platform_device *pdev) { - struct hid_sensor_hub_device *hsdev = dev_get_platdata(&pdev->dev); + struct device *dev = &pdev->dev; + struct hid_sensor_hub_device *hsdev = dev_get_platdata(dev); int ret = 0; static const char *name = "gyro_3d"; struct iio_dev *indio_dev; struct gyro_3d_state *gyro_state; - indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*gyro_state)); + indio_dev = devm_iio_device_alloc(dev, sizeof(*gyro_state)); if (!indio_dev) return -ENOMEM; platform_set_drvdata(pdev, indio_dev); @@ -284,12 +285,10 @@ static int hid_gyro_3d_probe(struct platform_device *pdev) &gyro_state->common_attributes, gyro_3d_sensitivity_addresses, ARRAY_SIZE(gyro_3d_sensitivity_addresses)); - if (ret) { - dev_err(&pdev->dev, "failed to setup common attributes\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to setup common attributes\n"); - indio_dev->channels = devm_kmemdup(&pdev->dev, gyro_3d_channels, + indio_dev->channels = devm_kmemdup(dev, gyro_3d_channels, sizeof(gyro_3d_channels), GFP_KERNEL); if (!indio_dev->channels) return -ENOMEM; @@ -297,10 +296,8 @@ static int hid_gyro_3d_probe(struct platform_device *pdev) ret = gyro_3d_parse_report(pdev, hsdev, (struct iio_chan_spec *)indio_dev->channels, HID_USAGE_SENSOR_GYRO_3D, gyro_state); - if (ret) { - dev_err(&pdev->dev, "failed to setup attributes\n"); - return ret; - } + if (ret) + dev_err_probe(dev, ret, "failed to setup attributes\n"); indio_dev->num_channels = ARRAY_SIZE(gyro_3d_channels); indio_dev->info = &gyro_3d_info; -- 2.34.1