[PATCH v2 1/2] iio: gyro: hid-sensor-gyro-3d: Remove redundant dev_err()
Sanjay Chitroda <[email protected]>
| Newsgroups | org.kernel.feeds.b4-sent,org.kernel.vger.linux-iio,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260724-24-july-hid-gyro-dev-log-clenaup-v2-1-01671b07b181@gmail.com> |
Respective APIs used during probe setup already emit detailed error messages or return appropriate standard error codes on failure. Remove the redundant/dead driver-specific dev_err() calls to avoid duplicate error reporting. Signed-off-by: Sanjay Chitroda <[email protected]> --- drivers/iio/gyro/hid-sensor-gyro-3d.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c index 58250a972567..bcf53e267701 100644 --- a/drivers/iio/gyro/hid-sensor-gyro-3d.c +++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c @@ -291,10 +291,8 @@ static int hid_gyro_3d_probe(struct platform_device *pdev) indio_dev->channels = devm_kmemdup(&pdev->dev, gyro_3d_channels, sizeof(gyro_3d_channels), GFP_KERNEL); - if (!indio_dev->channels) { - dev_err(&pdev->dev, "failed to duplicate channels\n"); + if (!indio_dev->channels) return -ENOMEM; - } ret = gyro_3d_parse_report(pdev, hsdev, (struct iio_chan_spec *)indio_dev->channels, @@ -313,26 +311,20 @@ static int hid_gyro_3d_probe(struct platform_device *pdev) ret = hid_sensor_setup_trigger(indio_dev, name, &gyro_state->common_attributes); - if (ret < 0) { - dev_err(&pdev->dev, "trigger setup failed\n"); + if (ret < 0) return ret; - } gyro_state->callbacks.send_event = gyro_3d_proc_event; gyro_state->callbacks.capture_sample = gyro_3d_capture_sample; gyro_state->callbacks.pdev = pdev; ret = sensor_hub_register_callback(hsdev, HID_USAGE_SENSOR_GYRO_3D, &gyro_state->callbacks); - if (ret < 0) { - dev_err(&pdev->dev, "callback reg failed\n"); + if (ret < 0) goto error_remove_trigger; - } ret = iio_device_register(indio_dev); - if (ret) { - dev_err(&pdev->dev, "device register failed\n"); + if (ret) goto error_remove_callback; - } return ret; -- 2.34.1