[PATCH 01/28] dt-bindings: phy: qcom: Describe QMP USB and UFS PHY vdda-phy/vdda-pll voltages

Manivannan Sadhasivam <[email protected]> Mon, 03 Aug 2026 08:33:59 +0200
Newsgroups org.kernel.feeds.b4-sent,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
The vdda-phy and vdda-pll supplies of the QMP USB and UFS PHYs are
frequently swapped in devicetrees, as the naming does not make clear
which supply expects which voltage. Document that vdda-phy is around
0.8V and vdda-pll is around 1.2V, with the exact voltage varying per
SoC, so that the correct supplies can be assigned.

Reported-by: Konrad Dybcio <[email protected]>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <[email protected]>
---
 .../devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml   | 10 ++++++++--
 .../devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml  | 10 ++++++++--
 .../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml   | 12 +++++++++---
 .../bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml         | 12 +++++++++---
 .../bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml          | 10 ++++++++--
 5 files changed, 42 insertions(+), 12 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml
index 1636285fbe53..4cbcf54aef2c 100644
--- a/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml
@@ -39,9 +39,15 @@ properties:
       - const: phy
       - const: phy_phy
 
-  vdda-phy-supply: true
+  vdda-phy-supply:
+    description:
+      Supply for the PHY, typically around 0.8V, though the exact voltage
+      varies per SoC.
 
-  vdda-pll-supply: true
+  vdda-pll-supply:
+    description:
+      Supply for the PLL, typically around 1.2V, though the exact voltage
+      varies per SoC.
 
   "#clock-cells":
     const: 0
diff --git a/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml
index efb465c71c1b..9dbe49afaa6c 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml
@@ -40,9 +40,15 @@ properties:
       - const: phy_phy
       - const: dp_phy
 
-  vdda-phy-supply: true
+  vdda-phy-supply:
+    description:
+      Supply for the PHY, typically around 0.8V, though the exact voltage
+      varies per SoC.
 
-  vdda-pll-supply: true
+  vdda-pll-supply:
+    description:
+      Supply for the PLL, typically around 1.2V, though the exact voltage
+      varies per SoC.
 
   "#clock-cells":
     const: 1
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
index b2c5c9a375a3..968a700d2a55 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
@@ -81,9 +81,15 @@ properties:
     items:
       - const: ufsphy
 
-  vdda-phy-supply: true
-
-  vdda-pll-supply: true
+  vdda-phy-supply:
+    description:
+      Supply for the PHY, typically around 0.8V, though the exact voltage
+      varies per SoC.
+
+  vdda-pll-supply:
+    description:
+      Supply for the PLL, typically around 1.2V, though the exact voltage
+      varies per SoC.
 
   "#clock-cells":
     const: 1
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
index 01342823e57f..532afa116ba0 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
@@ -64,9 +64,15 @@ properties:
       - const: phy
       - const: phy_phy
 
-  vdda-phy-supply: true
-
-  vdda-pll-supply: true
+  vdda-phy-supply:
+    description:
+      Supply for the PHY, typically around 0.8V, though the exact voltage
+      varies per SoC.
+
+  vdda-pll-supply:
+    description:
+      Supply for the PLL, typically around 1.2V, though the exact voltage
+      varies per SoC.
 
   refgen-supply: true
 
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
index 4eff92343ce4..865395fe1416 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
@@ -69,9 +69,15 @@ properties:
       - const: phy
       - const: common
 
-  vdda-phy-supply: true
+  vdda-phy-supply:
+    description:
+      Supply for the PHY, typically around 0.8V, though the exact voltage
+      varies per SoC.
 
-  vdda-pll-supply: true
+  vdda-pll-supply:
+    description:
+      Supply for the PLL, typically around 1.2V, though the exact voltage
+      varies per SoC.
 
   refgen-supply: true
 

-- 
2.43.0