[PATCH] dt-bindings: hwmon: microchip,emc2305: add vcc-supply and #cooling-cells
Vincent Jardin <[email protected]>
| Newsgroups | org.kernel.feeds.b4-sent,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-hwmon,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260824-for-upstream-dt-emc2305-vcc-cooling-v1-1-cd3b53dfb5d4@free.fr> |
Both properties are missing, so a board that supplies either fails with dtbs_check: fan-controller@2c (microchip,emc2305): '#cooling-cells', 'vcc-supply' do not match any of the regexes: '^fan@[0-4]$', '^pinctrl-[0-9]+$' The #cooling-cells property belongs to the controller node, which is where the driver actually registers. Two cells is what that registration needs: a cooling-maps entry references the fan as <&emc2305 min max>. Two cells also documents what the driver supports today. The pwm-separate path registers one cooling device per PWM against the same node, and they all get cdev_id 0, so no cell count can tell them apart. That is a driver issue, noted here but not addressed. The examples in this binding put that property on the fan@N subnodes instead, which does not match what the driver does: they are left alone here rather than changed blind. vcc-supply describes the chip's own rail, which matters on boards where the sensor sits behind a switched supply. Signed-off-by: Vincent Jardin <[email protected]> --- Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml b/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml index 8c2548539d7fd..47640214de100 100644 --- a/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml +++ b/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml @@ -44,6 +44,11 @@ properties: - 0 (Open-Drain) - 1 (Push-Pull) + vcc-supply: true + + "#cooling-cells": + const: 2 + patternProperties: '^fan@[0-4]$': $ref: fan-common.yaml# --- base-commit: 0a0d1d55dad570724bf8c7ea83409639cfb4be9b change-id: 20260824-for-upstream-dt-emc2305-vcc-cooling-251655c99ef8 Best regards, -- Vincent Jardin <[email protected]>