Re: [PATCH b4 00/12] Enable stricter local checks
Tamir Duberstein <[email protected]>
| Newsgroups | org.kernel.linux.tools |
|---|---|
| Message-ID | <CAJ-ks9n_cg=NNFKYKoJPR1AzzxMRa7CB3i2Vz2SgWbG=ZeoSxg@mail.gmail.com> |
On Tue, Apr 7, 2026 at 12:48 PM Tamir Duberstein <[email protected]> wrote: > > This series makes b4 local developer checks enforceable from the > review TUI and makes the repo clean under ruff, mypy, pyright, and ty. > > The early patches set ruff formatting and import behavior, make the > test environment reproducible under uv, and type the misc helpers enough > for whole-repo mypy. The middle patches tighten mypy and pyright, then > add ty with all rules enabled and bump the Python requirement to 3.11 > because the code already uses 3.11-only syntax. > > The last patch wires the review TUI to run the same local checks through > a JSON-emitting series check helper, so reviewers can see ruff, mypy, > pyright, ty, and pytest results from b4 itself. > > Signed-off-by: Tamir Duberstein <[email protected]> Hi Konstantin, any interest in these changes? I see some of b4 has been moved to liblore, but I believe that package has the same type checking gaps. No worries if you're not interested in these patches, but I wanted to demonstrate that mypy (even in strict mode) is still quite lax (e.g. it doesn't warn on unreachable code). Cheers. Tamir