Re: [PATCH 09/14] Type from_git_config keyword arguments

On Fri, 10 Apr 2026 18:38:00 -0400, Tamir Duberstein <[email protected]> wrote:
> diff --git a/src/liblore/node.py b/src/liblore/node.py
> index 1b0463e..4835169 100644
> --- a/src/liblore/node.py
> +++ b/src/liblore/node.py
> @@ -29,6 +30,19 @@ from liblore.utils import (
>  
>  logger = logging.getLogger(__name__)
>  
> +if TYPE_CHECKING:
> +    from typing_extensions import Unpack
> +
> +
> +class _LoreNodeInitKwargs(TypedDict, total=False):
> +    fallback_urls: list[str] | None
> +    auto_probe: bool
> +    probe_timeout: float
> +    probe_ttl: int
> +    add_auth_headers: bool
> +    cache_dir: str

`LoreNode.__init__` accepts `cache_dir: str | None`. This should be
`cache_dir: str | None` to match, otherwise `from_git_config(cache_dir=None)`
is going to be problematic.

-- 
KR