Re: b4 adds Link trailer although not asked to?

Matthias Beyer <[email protected]> Sun, 26 Apr 2026 13:38:39 +0200

Newsgroups	org.kernel.linux.tools
Message-ID	<cltup2qefzi25wupghnwxhls43ecxd7sp4j7rkzffr633pdlgg@g4ukbqcoor7f>

Hi again,

after playing some more, the issue did not appear with `b4 shazam` if I
did not specify `--add-link`.

Am Sun, Apr 26, 2026 at 12:21:34PM +0200, schrieb Matthias Beyer:
> [...]
> I am currently playing with b4 and am wondering why b4 adds a `Link:`
> trailer even though I did not specify `--add-link`.
> 
> There's no configuration file around
> 
>     git config list | grep b4 # no output
> 
> or something, here's what I did:
> 
>     notmuch show --format=mbox $SOME_NOTMUCH_QUERY | b4 am -m - -o -
> 
> and it prints the resulting patches with a `Link: ...`.
> 
> FWIW, I am not in the kernel context, so a lore.kernel.org link is wrong
> for my usecase (I know I can set an alternative mask, but I don't want
> any link in the resulting commits here).
> 
> The above was tested with b4 0.14.3 and 0.15.2.
> 
> The only source line in b4 that sets addlink=True is in
> 
>     src/b4/mbox.py:135
> 
> but I don't see how that line is hit in my case, because `addmsgid`
> should be False here (False by default).
> 
> Hope you can help me here,
> Best,
> Matthias

signature.asc (application/pgp-signature, 833 B)