Re: [PATCH v3 1/9] kernel/api: introduce kernel API specification framework
Nathan Chancellor <[email protected]>
| Newsgroups | org.kernel.linux.tools,org.kernel.vger.linux-api,org.kernel.vger.linux-doc,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kbuild,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kernel.vger.workflows |
|---|---|
| Message-ID | <177726106581.2478607.12645653803520391071.b4-review@b4> |
On Fri, 24 Apr 2026 12:51:21 -0400, Sasha Levin <[email protected]> wrote: > diff --git a/kernel/Makefile b/kernel/Makefile > index 6785982013dc..564315153643 100644 > --- a/kernel/Makefile > +++ b/kernel/Makefile > @@ -59,6 +59,9 @@ obj-y += dma/ > obj-y += entry/ > obj-y += unwind/ > obj-$(CONFIG_MODULES) += module/ > +obj-$(CONFIG_KAPI_SPEC) += api/ > +# Ensure api/ is always cleaned even when CONFIG_KAPI_SPEC is not set > +obj- += api/ If $(CONFIG_KAPI_SPEC) is not set, shouldn't obj-$(CONFIG_KAPI_SPEC) += api/ evaluate to obj- += api/ anyways? Why the duplication? This is the only place in the kernel where this would be needed? > > diff --git a/kernel/api/.gitignore b/kernel/api/.gitignore > new file mode 100644 > index 000000000000..ca2f632621cf > --- /dev/null > +++ b/kernel/api/.gitignore > @@ -0,0 +1,2 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +/generated_api_specs.c This appears unused? > > diff --git a/kernel/api/Kconfig b/kernel/api/Kconfig > new file mode 100644 > index 000000000000..d1072728742a > --- /dev/null > +++ b/kernel/api/Kconfig > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# Kernel API Specification Framework Configuration > +# > + > +config KAPI_SPEC > + bool "Kernel API Specification Framework" > + default n I think 'default n' is tautological since 'n' is the default for all bool symbols. Consider dropping it on all symbols throughtout this file. -- Nathan Chancellor <[email protected]>