Re: b4 review tui: patchwork integration

Matthieu Baerts <[email protected]>
Newsgroups org.kernel.linux.tools
Organization NGI0 Core
Message-ID <[email protected]>
Hi Konstantin,

Thank you for your reply!

On 28/04/2026 23:16, Konstantin Ryabitsev wrote:
> On Tue, Apr 28, 2026 at 01:02:11PM +0200, Matthieu Baerts wrote:
>> Hi Konstantin,
>>
>> It's great to have a built-in patchwork support!
>>
>> Something that is blocking me to use 'b4 review tui' more is that not
>> all Patchwork status are supported, e.g. I cannot mark a patch as
>> "Queued", and delegate it to someone.
> 
> The issue here is that patchwork doesn't expose what statuses are available
> via any API call, so we can either hardcode it to whatever we have on
> patchwork.kernel.org (and have it not work for any other patchwork instance),
> or we can hack patchwork to expose it. :) Either option is... not that great.

Could we eventually set all statuses in the config file?

For git-pw [1], I added them in my .git/config:

  $ git config pw.states

new,under-review,accepted,rejected,rfc,not-applicable,changes-requested,awaiting-upstream,superseded,deferred,mainlined,queued,needs-ack,handled-elsewhere

(I think I'm missing 'in-next')

The ones from kernel.org could be added to the documentation as an
example.

[1] https://github.com/getpatchwork/git-pw/

>> I see that patches are automatically marked as "under-review", but it
>> would be nice to assign myself as well, so others know who is reviewing
>> what. Eventually, it might be good to ask for a confirmation: I might
>> use the "review" mode simply to validate a patch reviewed by someone else.
> 
> OK, I'll take a poke.

Thank you!

>> Something that was already reported by someone else I think is that the
>> "patchwork" view only shows the "Action Required" ones, and it is not
>> possible to show more patches.
> 
> Kinda same limitation as the one I described above, but I can take a closer
> look.

Maybe another config option, instead of using hardcoded values?

>> One last thing: it might be good to have other automations, e.g. when
>> the "Reviewed-by" tag is sent from the "review" mode, then the patch
>> could be marked as "Queued" on Patchwork.
> 
> Noted!
> 
>> (And eventually, have a way to run script as an action during the review
>> and from the "patchwork" view, e.g. to apply a patch using a script that
>> will do extra quick checks and select the right tree.)
> 
> Hm... from the patchwork view I'm not so sure, but I can take a look.
Only from the "tracked" view is probably enough.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.