Re: [PATCH b4] config: add send-me-too configuration
Konstantin Ryabitsev <[email protected]> Wed, 10 Jun 2026 02:36:08 +0000
| Newsgroups | org.kernel.linux.tools |
|---|---|
| Message-ID | <178105896854.172387.14154860070343570175.b4-review@b4> |
On Wed, 29 Apr 2026 14:49:46 +0800, Jeremy Kerr <[email protected]> wrote: > diff --git a/docs/contributor/send.rst b/docs/contributor/send.rst > index ba18ef5..5769cd7 100644 > --- a/docs/contributor/send.rst > +++ b/docs/contributor/send.rst > @@ -321,7 +321,9 @@ Command line flags > :ref:`contributor_settings`). > > ``--not-me-too`` > - Removes your own email address from the recipients. > + Removes your own email address from the recipients. This can be set in the > + configuration using the :term:`b4.send-me-too`, setting to `no`. (see > + :ref:`contributor_settings`). Small nit -- you probably wanted to use ``no`` here, not `no` (trips me up all the time, too). > > diff --git a/src/b4/ez.py b/src/b4/ez.py > index 3e81138..39168e6 100644 > --- a/src/b4/ez.py > +++ b/src/b4/ez.py > @@ -2252,7 +2252,8 @@ def cmd_send(cmdargs: argparse.Namespace) -> None: > ccdests.append(btr.addr) > > excludes = b4.get_excluded_addrs() > - if cmdargs.not_me_too: > + conf_me_too = config.get('send-me-too').lower() > + if cmdargs.not_me_too or conf_me_too in {'no', 'n', 'false'}: Safer to do: conf_me_too = str(config.get('send-me-too', 'yes')).lower() Also, I believe, mypy won't yell at you then. :) -- Konstantin Ryabitsev <[email protected]>